Extract hoisted variables from dead branches #3752
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3749
Description
When attempting to fix #3749, I found that there are quite a few more ways of having variable declarations in dead branches that would cause Rollup to crash. This should fix them all by gathering all hoisted variables in dead branches and rendering them explicitly as a separate
var
declaration.While doing this I also learned that in strict mode,
function
declarations are not hoisted across block scope boundaries; this made things quite a bit easier. This will make code more concise while also fixing the original issue.